Kevin, Looks good for me.
-Dmitry On 2014-01-22 21:43, Kevin Walls wrote: > Hi, > > Can I just get a review of this jtreg tag change in a testcase. The > testcase specifically contains a utf8 character and to make sure it > compiles everywhere we need to specify -encoding on the @compile line, > and then add an @run line: > > webrev > http://cr.openjdk.java.net/~kevinw/8032466/webrev.00/ > > bug > https://bugs.openjdk.java.net/browse/JDK-8032466 > > (if the testcase runs fine without this change, in jtreg locally you can > make it fail by setting -encoding ascii) > > Thanks! > Kevin -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.