Hi,
Yes, change looks good I think.
(I was just pleasantly surprised that SA_ALTROOT is respected by the
product build where libsaproc_audit does not exist. But libsaproc_open
is the open routine that respects the alt_root, and it needs to get
called by libproc in order to fixup paths for a transported core file,
but I can't immediately see the magic link that makes that happen, when
the the audit library isn't there...)
Thanks
Kevin
On 27/01/14 13:36, Dmitry Samersoff wrote:
Staffan,
I had no ideas what libsaproc_audit is for, code at
hotspot/agent/src/os/solaris/proc/saproc_audit.cpp
didn't get me a clue.
new build system doesn't build it and it seems like everything works fine.
-Dmitry
On 2014-01-27 17:18, Staffan Larsen wrote:
I wasn’t aware that these makefiles and utilities were still around,
much less in use. We really should consolidate them into the main
hotspot makefiles.
Anyway, changes look fine.
/Staffan
On 19 jan 2014, at 11:03, Dmitry Samersoff
<dmitry.samers...@oracle.com> wrote:
Hi Everyone,
Please review small SA fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-7010732/webrev.01/
Notice, new build system doesn't build libsaproc_audit.so so the
fix affects old-style usage only.
-Dmitry
-- Dmitry Samersoff Oracle Java development team, Saint Petersburg,
Russia * I would love to change the world, but they won't give me
the sources.
