Looks good, but should we maybe have a comment in JInfo.java about the structure being needed for testing? Just looking at the code this is not obvious.
/Staffan On 7 apr 2014, at 12:46, Jaroslav Bachorik <[email protected]> wrote: > Hi, > > Sorry for the noise but I need to get the fix re-reviewed. > Due to the way jtreg cooperates with TestNG when runnning in agentvm I can > not use package private methods or constructor or fields. > > The updated patch - http://cr.openjdk.java.net/~jbachorik/8039080/webrev.01 - > makes the JInfo constructor a private one and removes the package private > getters. The test is using reflection to create new instances of JInfo and to > assert its state. > > Thanks, > > -JB-
