Fredrik,
1. I'm not sure we have to provide user-configurable decoration.
It add complication to logger because not all decorations
available for all components and it creates a burden
for customer support because all tools would have
to support different log formats.
2. Backend might be a better word than adapter.
STDOUT, STDERR and text file is essentially the same backend.
3. I'm not sure we have to care about log rotation by size, time etc -
everything is done here during last 20 years, and there are lots of
tools that do it.
But, for file backend, we have to provide jcmd command to close
current log and start new one at runtime.
4. Proposed VM API is too verbose and require lots of typing.
Also to add new component you have to touch log code, split
or rename components is also problematic.
So it might be better to use
Log::set_component(Log::gc);
Log::warn( format, ... );
Log::error();
Log::trace();
Log::debug()
Log::start();
Log::add( format, ... )
Log::commit(Log::level());
5. I'm not sure that transaction is the best term here.
-Dmitry
On 2014-05-16 12:47, Fredrik Arvidsson wrote:
> Hi all
> Please help me review this updated version of the JEP-158 Unified JVM
> Logging that was pushed today to the JEP repository.
>
> Since the service posting the JEPs to http://openjdk.java.net/jeps/ site
> seems to be non working at the moment I am linking directly to the HG
> repository instead.
>
> The updated JEP can be found here in raw markdown format:
> http://hg.openjdk.java.net/jep/jeps/file/b04a394c4df4/jep-158.md
>
> Primarily I would like to have feedback on the overall functionality
> scope, the logging API and the command line argument format. All type of
> comments are of course welcome, but I would like to stay away from any
> implementation specifics at this point.
>
> I have a POC implementation which is nearly feature complete up and
> running and it looks good so far.
>
> /Fredrik
>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
