Looks good to me!
Thanks for looking at this Kevin, /peter On 20 May 2014, at 13:14, Kevin Walls <[email protected]> wrote: > Hi - any comments? 8-) > > On 12/05/14 16:02, Kevin Walls wrote: >> >> Hi, >> >> I'd like to get a review of this test change. It assumed that jmap would >> have permission to run on a process that the test itself created, but this >> is not necessarily the case. >> >> Here I'm considering it OK to skip (pass) the test where jmap fails to >> attach. The test itself was not platform-specific and as long as we have >> other platforms where jmap step will work, we are testing for this problem. >> >> bug: >> https://bugs.openjdk.java.net/browse/JDK-8039995 >> >> webrev: >> http://cr.openjdk.java.net/~kevinw/8039995/webrev.00/ >> >> Thanks >> Kevin >
