Hi - I think this is too late, but just a note that I'd started a review request on a version of that test which would fail gracefully (pass) if it wasn't able to use jmap to attach.

But I left that change (bug 8039995, on this alias) pending, waiting to find out if it was irrelevant - i.e. whether we're just making a mistake in the way we do these tests - shouldn't we be running SA tests in an environment where SA features are able to work: either running as root as required on some systems, or at least with the kernel.yama.ptrace_scope = 0 on some Linux systems.

Just wanted to make sure these threads are joined up...

Thanks
Kevin


On 02/06/14 18:28, Staffan Larsen wrote:
Looks good!

Thanks,
/Staffan

On 2 jun 2014, at 17:29, Mikael Auno <mikael.a...@oracle.com> wrote:

Hi,

Could I please have a review of this very small fix.

webrev: http://cr.openjdk.java.net/~miauno/8044540/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8044540

Verified locally.

Thanks,
Mikael

Reply via email to