Looks good!

Thanks,
/Staffan

On 15 aug 2014, at 16:55, Christian Tornqvist <[email protected]> 
wrote:

> Hi,
>  
> This is a small update to NMTHelper.java to make it work with recent changes 
> in the NMT implementation that changed the output format a bit.
>  
> I’ve tested the change locally using java\lang\instrument\RedefineBigClass.sh 
> and java\lang\instrument\RetransformBigClass.sh
>  
> Webrev doesn’t seem to like whitespace-only changes so I can’t post a webrev, 
> I’m pasting the diff here instead:
>  
> diff -r 362a6ea9bc84 test/java/lang/instrument/NMTHelper.java
> --- a/test/java/lang/instrument/NMTHelper.java  Thu Aug 14 15:54:04 2014 -0700
> +++ b/test/java/lang/instrument/NMTHelper.java  Fri Aug 15 10:43:15 2014 -0400
> @@ -32,8 +32,8 @@
>          executeDcmd("vmNativeMemory", "baseline");
>      }
>  
> -    // Total:  reserved=3484685KB  +293KB, committed=266629KB +293KB
> -    private static Pattern totalLine = Pattern.compile("^Total:  
> reserved=\\d+KB  .*KB, committed=\\d+KB (.*)KB$");
> +    // Total: reserved=3484685KB +293KB, committed=266629KB +293KB
> +    private static Pattern totalLine = Pattern.compile("^Total: 
> reserved=\\d+KB .*KB, committed=\\d+KB (.*)KB$");
>  
>      public static long committedDiff() throws Exception {
>          String res = (String) executeDcmd("vmNativeMemory", "detail.diff");
>  
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8055012
>  
> Thanks,
> Christian

Reply via email to