Hi Fredrik, A couple of comments: - I would prefer if the new callback was unified with the one that exists on Windows so that we have only on callback-based API for listing dynamic libraries. - If you do that, then would you also clean up enumerate_modules() on windows to get rid of the non-NT support? - Smaller: I think “address” is a better type to use instead of “u8”.
Thanks /Staffan On 28 aug 2014, at 15:54, Fredrik Arvidsson <[email protected]> wrote: > Hi > > Please help me review this small enhancement. > > Webrev: http://cr.openjdk.java.net/~farvidsson/8056242/webrev.00/index.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8056242 > > Cheers > /F
