On 07/10/2014 07:26, Thomas Stüfe wrote:
Hi all,
We saw crashes when connecting to a target VM using
com.sun.tools.attach.WindowsVirtualMachine when injecting VM was
compiled with /RTC1.
The error turned out to be in VirtualMachineImpl.c: the function
"jvm_attach_thread_func" - the one which is injected into the target
VM and used as thread entry point for CreateRemoteThread() - must be
compiled with runtime checks disabled in order to keep the
code-to-inject position independent.
Using /rtc1 will cause the Microsoft compiler to generate relative
calls to a check function ("_RTC_CheckEsp") which will not work if
code is planted in target process at a different address.
This change adds a pragma to locally disable the runtime checks and
re-enable them below the function.
http://cr.openjdk.java.net/~simonis/webrevs/8059868/
<http://cr.openjdk.java.net/%7Esimonis/webrevs/8059868/>
This make sense to me.
A very tiny comment is that we should have use consistent spacing in the
#pragma values (check_stack and runtime_checks should be consistent, I
don't think it matters which way).
-Alan
