With Mandy’s suggestions this looks good to me too. /Staffan
> On 29 okt 2014, at 20:34, Mandy Chung <mandy.ch...@oracle.com> wrote: > > > On 10/29/2014 6:50 AM, Jaroslav Bachorik wrote: >> Please review the following change >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8061616 >> Webrev : >> (jdk): http://cr.openjdk.java.net/~jbachorik/8061616/jdk/webrev.00/ >> (hotspot): http://cr.openjdk.java.net/~jbachorik/8061616/hotspot/webrev.00/ >> > > share/classes/sun/management/HotSpotDiagnostic.java > line 105-110, 117-122: you can replace with new IAE(String, Throwable cause) > The original code was written before that IAE constructor was added. > > test/com/sun/management/HotSpotDiagnosticMXBean/GetDoubleVMOption.java > you can take out line 28 > > Looks okay otherwise. > > Mandy
