Dmitry,

It looks good.
Reviewed.
Thank you for fixing two more cases!

Thanks,
Serguei

On 12/11/14 12:48 AM, Dmitry Samersoff wrote:
Serguei,

Fixed two more missed error checks (in-place, press shift-reload)

http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/

-Dmitry

On 2014-12-10 01:30, serguei.spit...@oracle.com wrote:
Hi Dmitry,

The fix looks good.

However, there are a couple of more places in that file
where the result of the jvmtiAllocate() is not checked:

   68         utf8msg = (jbyte*)jvmtiAllocate(maxlen+1);

  393     buf = jvmtiAllocate(len*3+3);


Could you fix this as well?


Thanks,
Serguei


On 12/9/14 11:50 AM, Dmitry Samersoff wrote:
Hi Everybody,

Please review small fix.

http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/

JDWP crash if allocation fails because it calls strcpy before
check of allocation results.

-Dmitry



Reply via email to