> On 13 jan 2015, at 06:28, David Holmes <david.hol...@oracle.com> wrote: > > Hi Jeremy, > > On 13/01/2015 4:32 AM, Jeremy Manson wrote: >> Hi folks, >> >> This was long forgotten, seems to have been lost in the shuffle. I've >> done it, since we could use it, too: >> >> https://bugs.openjdk.java.net/browse/JDK-6588467 >> http://cr.openjdk.java.net/~jmanson/6588467/webrev.00/ > > Codewise this all appears fine to me.
Thanks for doing this. I have only scanned the code, but did not see any test. Could you please add tests for the new API? >> Since it is an API change (albeit an uncontroversial one), it will have >> to go through whatever the super-secret API change review process is >> that you folks do. > > Not sure if this just needs an API tweak or a JMX spec revision. If the > latter then this might be a big deal. But I'll leave that to the official > serviceability folk :) No spec revision is needed, same process as for all API changes. Unfortunately I don’t have the time to drive that, so hoping someone else can jump in. /Staffan > > Cheers, > David > >> Thanks! >> >> Jeremy