I'm not a "R"eviewer, so you still need one. (Forgot to mention in my
reply email).
Thanks
Yumin
On 1/14/2015 8:33 AM, Jiangli Zhou wrote:
Hi Yumin,
Thanks for the review! Will fix the copyright.
Thanks,
Jiangli
On 01/13/2015 07:56 PM, Yumin Qi wrote:
Looks good to me. Could you update the copyright year?
Thanks
Yumin
On 1/13/2015 4:50 PM, Jiangli Zhou wrote:
Hi,
Please review the fix for JDK-8067982
<https://bugs.openjdk.java.net/browse/JDK-8067982> (Some jcmd
/gc/heap_dump tests failed: hprof output contains warning or error).
The jcmd heap_dump tests failed due to incomplete symbol information
in the dump output. The shared symbols are not included in the dump
output because they are not in the SymbolTable, but in a separate
table within the shared archive. The fix is to include the shared
symbols when iterating all symbols in
SymbolTable::symbols_do(SymbolClosure).
http://cr.openjdk.java.net/~jiangli/8067982/webrev.00/
Tested with vm.jcmd tests and jprt. All failed jcmd heap dump tests
passed with the fix.
Thanks,
Jiangli
