Looks good to me.
Do you plan to push the jdk side change to remove com.sun.tracing
together with the hotspot change? I notice that you have a separate bug
JDK-8062303 for jdk change. It's fine to choose to do. It'd also be
fine to push the jdk change together with this hotspot change.
Mandy
On 1/14/15 6:05 AM, Jaroslav Bachorik wrote:
Please, review the following removal of functionality.
Issue : https://bugs.openjdk.java.net/browse/JDK-8068976
Webrev: http://cr.openjdk.java.net/~jbachorik/8068976/webrev.00
JDK-8062303 [1] requests the removal of com.sun.tracing API. This API
was added as experimental in JDK7 [2][3] and haven't seen any
significant uptake since then.
JSDT builds on top of the com.sun.tracing API and provides the bridge
to DTrace. It allows Java programs to fire custom DTrace probes. As an
implementation of com.sun.tracing API it needs to be removed before
proceeding with the removal of that API.
This change is basically an anti-delta to [4] - minus the changes not
related to JSDT and/or DTrace.
This change passes all the regression and JCK tests.
Thanks,
-JB-
[1] https://bugs.openjdk.java.net/browse/JDK-8062303
[2] https://bugs.openjdk.java.net/browse/JDK-6537506
[3] https://bugs.openjdk.java.net/browse/JDK-7037081
[4] http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/018d5b58dd4f
