Looks good. -Tao (tamao) On Mon, Feb 2, 2015 at 7:51 AM, Yasumasa Suenaga <yasue...@gmail.com> wrote:
> Hi, > > I need more reviewer. > Could you review it? > > http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/ > > Thanks, > > Yasumasa > 2015/01/28 17:24 "Staffan Larsen" <staffan.lar...@oracle.com>: > > Looks good! >> >> Thanks, >> /Staffan >> >> > On 28 jan 2015, at 05:48, Yasumasa Suenaga <yasue...@gmail.com> wrote: >> > >> > Hi Staffan, Kirk, >> > >> > I agree to set "Diagnostic Command" to GCCause. >> > So I applied it to new patch. >> > >> > http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/ >> > >> > Could you review it again? >> > >> > >> > Thanks, >> > >> > Yasumasa >> > >> > >> > On 2015/01/28 5:06, Kirk Pepperdine wrote: >> >> Hi Staffan, >> >> >> >>>> >> >>>> Anyway, it’s a record in a GC log so I don’t see the value of >> GC.run. Certainly “DiagCmd" or even "Diagnostic Command” seems sufficient >> given the context. >> >>> >> >>> Let’s go with “Diagnostic Command”, then. >> >> >> >> Thank you! >> >> >> >> Regards, >> >> Kirk >> >> >> >>
