Looks good! (And verified on my mac) Thanks, /Staffan
> On 13 feb 2015, at 10:40, Jaroslav Bachorik <jaroslav.bacho...@oracle.com> > wrote: > > On 13.2.2015 03:36, David Holmes wrote: >> Hi Jaroslav, >> >> Looks reasonable - but I can't vouch for MacOSX commands. > > I am not a lucky Mac owner neither. I confirmed the format running the test > on the test farm Mac machines only. > >> >> Minor nit: >> >> 111 // total used free shared buffers >> cached >> 112 // Mem: 16533540864 13638467584 2895073280 >> 534040576 1630248960 6236909568 >> >> The labels in #111 need to move across. > > Ah, will move it :) Thanks > > -JB- > >> >> Thanks, >> David >> >> On 13/02/2015 12:23 AM, Jaroslav Bachorik wrote: >>> On 12.2.2015 15:16, Jaroslav Bachorik wrote: >>>> Please, review the following test change >>>> >>>> Issue : https://bugs.openjdk.java.net/rest/api/latest/issue/JDK-8072908 >>> >>> Should be https://bugs.openjdk.java.net/browse/JDK-8072908 >>> >>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8072908/webrev.00 >>>> >>>> The existing shell test fails for MacOS when there is no swap configured >>>> due to the pattern processing problem. >>>> >>>> This patch converts the shell test to a plain Java one and makes sure >>>> the test does not break for zero size swap on MacOS (or any other OS for >>>> that matter) >>>> >>>> Thanks, >>>> >>>> -JB- >>> >
