Hi Staffan,
On 10.3.2015 11:21, Staffan Larsen wrote:
During attach, if the .java_pid file is not secure we currently say "well-known file
is not secure". This can be enhanced to say _why_ the file is not considered secure.
bug: https://bugs.openjdk.java.net/browse/JDK-8074812
webrev: http://cr.openjdk.java.net/~sla/8074812/webrev.00/
Note that it is safe to call JNU_ReleaseStringPlatformChars after the calls to
JNU_ThrowIOException since the latter don’t actually change the control flow.
Makes one wonder why it wasn't there since beginning :)
The fix looks good - just a nit
@src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c#28 the
'#include "jvm.h"' seems to be superfluous. This include has not been
added to any of the other modified files.
-JB-
Thanks,
/Staffan
