On 23.3.2015 08:50, Staffan Larsen wrote:
diagnosticCommand.cpp:
- Should SetVMFlagDCmd really be inside "#if INCLUDE_SERVICES” ?
Probably not. On the other hand, the JVMTIDataDumpDCmd registration
should probably be guarded by #if INCLUDE_JVMTI
- L227-234: strange indentation
Fixed.
Updated webrev (+ removing the extraneous #include
"services/attachListener.hpp" in diagnosticCommand.hpp) :
http://cr.openjdk.java.net/~jbachorik/8054890/webrev.01
-JB-
/Staffan
On 19 mar 2015, at 10:59, Jaroslav Bachorik <jaroslav.bacho...@oracle.com>
wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8054890
Webrev: http://cr.openjdk.java.net/~jbachorik/8054890/webrev.00
This patch is about adding 2 new diagnostic commands - VM.set_flag and
JVMTI.data_dump.
VM.set_flag allows to set any writeable flag. It takes the flag name and the
flag value in textual form. The mutability of the flag and the value format
checks are forwarded to the shared vm management code.
JVMTI.data_dump will send the data dump request to JVMTI.
Both of these commands are covered by the corresponding tests.
Thanks,
-JB-
