Lois, Thank you very much for your findings.
We are going to remove the blank comments as you have suggested. If possible, however, we would prefer to pursue the copyrights issue under a different CR as this is another and not strictly related bulk change, which, probably, can be best achieved by an unrelated, script. I believe, there already is a separate CR for updating the copyrights. However if there's no such CR we are going to create a new one. Do you think it could be possible to have a separate CR for the copyrights issue (and if necessary to submit a new one)? Best regards, Alex ----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected], [email protected], [email protected], [email protected], [email protected] Sent: Tuesday, March 24, 2015 3:57:54 PM GMT +04:00 Abu Dhabi / Muscat Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests This looks good, thank you for making these changes! A couple of comments that I don't feel need another webrev but should be fixed before pushing. - copyrights on all the tests need to be updated - the following tests have a blank comment line before the new "@modules" line that could be removed test/gc/metaspace/TestMetaspacePerfCounters.java test/runtime/contended/Basic.java test/compiler/jsr292/CreatesInterfaceDotEqualsCallInfo.java test/compiler/cpuflags/RestoreMXCSR.java test/compiler/debug/VerifyAdapterSharing.java Thanks, Lois On 3/24/2015 8:09 AM, Yekaterina Kantserova wrote: > Notifying hotspot-dev as well. > > // Katja > > > > On 03/24/2015 11:48 AM, Alexander Kulyakhtin wrote: >> Could the reviewers, please, have a look at the proposed changes below? >> >> In addition, we are going to make a change to the TEST.ROOT file as >> indicated by Staffan in the mail below. >> >> Do you think the changes (plus the one-line change to the TEST.ROOT) >> can be pushed into the jdk? >> >> Best regards, >> Alex >> >> ----- Original Message ----- >> From: [email protected] >> To: [email protected] >> Cc: [email protected], [email protected] >> Sent: Friday, March 20, 2015 7:39:10 PM GMT +04:00 Abu Dhabi / Muscat >> Subject: Re: RFR: JDK-8075586: add @modules as needed to the open >> hotspot tests >> >> I haven’t looked at the changes in detail, but please change the >> requiredVersion in TEST.ROOT to 4.1 b11 as part of this change. >> >> Thanks, >> /Staffan >> >>> On 20 mar 2015, at 13:16, Alexander Kulyakhtin >>> <[email protected]> wrote: >>> >>> Hi, >>> >>> Could you, please, review the fix below. >>> >>> CR: https://bugs.openjdk.java.net/browse/JDK-8075586 >>> webrev: >>> http://cr.openjdk.java.net/~tpivovarova/akulyakh/8075586/webrev.00/ >>> >>> The fix adds @modules keyword to the existing hotspot tests, as >>> needed, so that the tests can access the required API when the new >>> modular architecture is in place. >>> >>> Best regards, >>> Alex >
