Hi Shanliang, Impressive work! I know how long it took you and how much effort went into this! This does look good.
One minor remark is that it might have been good to have a simple mechanical rule to transform the name of the MBean concrete implementation from the java.management module to the jdk.management module, since these concrete class names may need to be referred to in an application policy file. For instance - if we could say: << Implementation class names of MBeans which do not have a com.sun.management extension are unchanged (that is still true - I think). Implementation class names of MBeans which do have a com.sun.management extension are changed so that their package name moves from sun.management. to com.sun.management.internal. >> At this point however there doesn't seem to be such a simple pattern, apart from the fact that the implementation have moved to com.sun.management.internal. For instance we have: before: sun.management.OperatingSystemImpl after: java.management: sun.management.BaseOperatingSystemImpl jdk.management: com.sun.management.internal.OperatingSystemImpl before: sun.management.GarbageCollectorImpl after: java.management: sun.management.GarbageCollectorImpl jdk.management: com.sun.management.internal.GarbageCollectorExtImpl before: sun.management.ThreadImpl after: java.management: sun.management.ThreadImpl jdk.management: com.sun.management.internal.HotSpotThreadImpl But this is minor compared to the rest of the work, and maybe that could be left over for later - if that's ever needed. best regards, -- daniel On 31/03/15 18:39, shanliang wrote:
Please review this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8042901 Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8042901/00/ Some code within the module java.management is separated and moved to the new module jdk.management, the new module takes the implementation code for Oracle Corporation's platform extension to the implementation of the java.lang.management API and also the management interface for some other components for the platform. Thanks, Shanliang
