Looks good.
Thanks,
David
On 2/04/2015 10:35 PM, Dmitry Samersoff wrote:
Fix updated.
On 2015-04-02 15:05, Dmitry Samersoff wrote:
David,
On 2015-04-02 14:45, David Holmes wrote:
Hi Dmitry,
On 2/04/2015 9:27 PM, Dmitry Samersoff wrote:
Everybody,
Please review a small fix.
The fix goes to 9 and 8u at the same time.
http://cr.openjdk.java.net/~dsamersoff/JDK-8068007/webrev.01/
Not sure I understand the bug synopsis in relation to the fix. Sounds
like FindBugs complained about using a protected static field that was
set directly via a subclass. Not sure why. So now we have a private
field that can be set by anyone via a public method. Maybe the
setInstance method should be protected not public?
Agree - I'll update the fix.
But do we really care? Either ways seems fine to me if it silences
FindBugs.
Yes, this is the goal.
-Dmitry
