Dmitry,
I'm puzzled a little bit with the webrev.02:
agent/src/share/classes/com/sun/java/swing/ui/CommonToolBar.java
- buttonSize = new Dimension(CommonUI.buttconPrefSize);
+ buttonSize = new Dimension(CommonUI.getButtonPrefSize());
Why do you replace the CommonUI.buttconPrefSize with the
CommonUI.getButtonPrefSize() ?
It looks like a typo, did you really want to do one of the following:
- buttonSize = new Dimension(CommonUI.buttconPrefSize);
+ buttonSize = new Dimension(CommonUI.getButtconPrefSize());
In such a case, the fix must be updated in the
agent/src/share/classes/com/sun/java/swing/ui/CommonUI.java
+ public static Dimension getButtonPrefSize()
+ {
+ return buttonPrefSize;
+ }
=>
+ public static Dimension getButtconPrefSize()
+ {
+ return buttconPrefSize;
+ }
Thanks,
Serguei
On 4/3/15 2:27 PM, Dmitry Samersoff wrote:
Everybody,
Please, review updated webrev:
http://cr.openjdk.java.net/~dsamersoff/JDK-8067991/webrev.02/
Fixed a compilation error that wasn't caught during incremental build.
-Dmitry
On 2015-04-02 15:54, Dmitry Samersoff wrote:
Everybody,
Please review a small fix:
The fix goes to 9 and 8u at the same time.
http://cr.openjdk.java.net/~dsamersoff/JDK-8067991/webrev.01/
-Dmitry
