I just realize that you also need to add a check if SA can attach on the 
current platform. See the test in sa/jmap-hashcode:

if (!Platform.shouldSAAttach()) {
    System.out.println("SA attach not expected to work - test skipped.");
    return;
}

Thanks,
/Staffan

> On 21 maj 2015, at 10:13, Staffan Larsen <[email protected]> wrote:
> 
> Can we add some kind of validation of the output? Something simple, just to 
> verify that we actually ran what we think we ran.
> 
>> On 21 maj 2015, at 09:33, Yekaterina Kantserova 
>> <[email protected]> wrote:
>> 
>> Hi,
>> 
>> Could I please have a review of this new test.
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8080828
>> webrev: http://cr.openjdk.java.net/~ykantser/8080828/webrev.00
>> 
>> This test will trigger the exception reported in 
>> https://bugs.openjdk.java.net/browse/JDK-8080155 if running with -Xcomp.
>> 
>> Thanks,
>> Katja
> 

Reply via email to