Looks good! Thanks, /Staffan
> On 27 maj 2015, at 15:02, Yekaterina Kantserova > <yekaterina.kantser...@oracle.com> wrote: > > Hi, > > Could I please have a review of this fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-8081037 > webrev root: http://cr.openjdk.java.net/~ykantser/8081037/webrev.00 > webrev jdk: http://cr.openjdk.java.net/~ykantser/8081037.jdk/webrev.00 > webrev hotspot: http://cr.openjdk.java.net/~ykantser/8081037.hotspot/webrev.00 > > From the bug: > "The problem is most likely that SA will pause the target process while it is > running. In this case, the target process is the same as the process that > launched SA. That process is also handling the output from SA over a pipe, > but when that pipe fills up the process cannot empty it and the SA process is > blocked because it cannot write any more output. Deadlock." > > The solutions is to start a separate target process. Dmitry Samersoff has > already created a test application for such cases so I've decided to move it > on the top level library instead of duplicating it. The test application will > reside under test/lib/share/classes/jdk/test/lib/apps and the test under > test/lib-test/jdk/test/lib/apps. > > Thanks, > Katja
