Hi, Can the changes below be approven? Although they are not strictly necessary, it is better to use external.lib.roots property instead of specifying too many upper-level directories, to take advantage of the latest jtreg version.
The issue itself has not been observed with the latest JDK9 build on any platform. CR: https://bugs.openjdk.java.net/browse/JDK-8114828 "wrong class file error when compiling tests" Webrev: http://cr.openjdk.java.net/~akulyakh/8114828/index.html Best regards, Alexander ----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected], [email protected] Sent: Thursday, July 16, 2015 4:39:14 PM GMT +03:00 Iraq Subject: Re: RFR: JDK-8114828: wrong class file error when compiling tests David, I was mistaken saying that jtreg does not allow @library to point out above the test root. On further investigation the issue appears to be an Aurora setup issue and the proposed earlier fix is not needed. We are investigating the cause of the issue. Best regards, Alexander ----- Original Message ----- From: [email protected] To: [email protected], [email protected], [email protected] Sent: Thursday, July 16, 2015 4:53:08 AM GMT +03:00 Iraq Subject: Re: RFR: JDK-8114828: wrong class file error when compiling tests Adding in hotspot-dev as there's a meta-question here Hi Alexander, On 16/07/2015 2:57 AM, Alexander Kulyakhtin wrote: > Hi, > > Could you, please, review these simple test-only changes: > > CR: https://bugs.openjdk.java.net/browse/JDK-8114828 "wrong class file error > when compiling tests" > (All the changed files belong to the Open JDK. Since the CR was submitted as > confidential, the issue is described in this mail below) > > Webrev: http://cr.openjdk.java.net/~akulyakh/8114828/index.html > > Before the change the @library tags in the tests pointed to the directory > above the tests repository. > With the jtreg b12 and above this is not allowed. Instead, the > external.lib.roots property should be used to specify any additional roots. > > The tests have been modified accordingly, so they now compile successfully. We currently have 272 tests in hotspot/test that specify some variant of: @library /testlibrary /../../test/lib Are these now all broken with jtreg b12? Why do these serviceability tests specify: test/lib/share/classes when all the other tests just specify: test/lib ? Thanks, David > Best regards, > Alexander >
