Hi Olivier,
I agree with the comments from Jaroslav.
A couple of minor comments.
+ if ( exitCode != 0 ) {
Unneeded extra spaces
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Parent process interrupted with exception :
\n " + e);
+ }
+
Why a call to interrupt() is needed?
I'd suggest to add a call e.printStackTrace().
Otherwise, it looks good.
Thanks,
Serguei
On 7/30/15 9:55 AM, olivier.lagn...@oracle.com wrote:
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.00/
We add tracing information to help diagnosing master bug problem
(https://bugs.openjdk.java.net/browse/JDK-8130339),
and we will monitor the quarantined runs to check for any failure and
get more diagnosis info.
Since the test already provides some information which is not
collected when it fails with timeout,
the idea is to collect subprocess I/O (stdout, stderr) by using
ProcessTools.startProcess rather
that OutputAnalyzer.executeProcess. The subprocess I/Os will be
collected while it's running
rather than waiting the subprocess termination.
A few additional infos have also been added to get more information.
Note that this "tracing" change should be temporary and will be
removed when a fix for 8130339 has been found.
Thanks,
Olivier.
