Looks good! Thanks, /Staffan
> On 2 dec. 2015, at 04:33, Jini George <jini.geo...@oracle.com> wrote: > > Hi all, > > This is a review request for the following defect related to Parfait cleanup: > > https://bugs.openjdk.java.net/browse/JDK-8139985 > <https://bugs.openjdk.java.net/browse/JDK-8139985> (JNI exception pending > in jdk/src/jdk/hprof/agent/share/native/libhprof/) > > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jingeorg/JDK-8139985/webrev.02/ > > <http://cr.openjdk.java.net/~dsamersoff/sponsorship/jingeorg/JDK-8139985/webrev.02/> > > This has been done for JDK8 only given that the hprof agent has been removed > for JDK9. I used the already available CHECK_EXCEPTIONS and > END_CHECK_EXCEPTIONS macros in hprof_util.c. Using these macros directly in > the other files did not help with removing the parfait error messages there, > due to the module dependencies being omitted because of cycles in the Module > Dependency Graph. > > > Thanks in advance, > > - Jini Susan George. > >
