On 15.12.2015 08:03, Alan Bateman wrote:
On 14/12/2015 16:55, Jaroslav Bachorik wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8138677
Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00
The problem is that the class UsageTrackerClient is accessing
RuntimeMXBean.getInputArguments() method via reflection to avoid
static dependency. However, with functional module boundaries this fails.
Since the functionality provided by RuntimeMXBean.getInputArguments()
is not, in fact, specific to the management subsystem, it makes sense
to move it out of jmm.h to jvm.h
Make sense to me too and the changes look okay. One small thing is that
make/share/makefiles/mapfile-vers seems to list the JVM_ functions in
alphabetic order, I assume you want to preserve that convention.
Sure. I will update this before pushing. Slipped my attention - I pasted
it there like JVM_GetInputArguments and then renamed it :(
Thanks for catching this.
-JB-
-Alan.
