On 16.12.2015 13:05, Alexander Kulyakhtin wrote:
Hi,
Could you, please, review this small test-only fix:
CR: https://bugs.openjdk.java.net/browse/JDK-8145408 "com/sun/jdi/BreakpointWithFullGC.sh:
Required output "Full GC" not found"
Webrev:
http://cr.openjdk.java.net/~akulyakh/8145408/test/com/sun/jdi/BreakpointWithFullGC.sh.udiff.html
The test, among other things, verifies that an indication of a Full GC event is
present in the output.
Recently, such an indication has been changed from similar to:
[Full GC (System.gc()) 2663K->2663K(31744K), 0.0034321 secs]
to similar to:
[3.326s][info ][gc] GC(10) Pause Full (System.gc()) 11M->3M(12M) (3.312s,
3.326s) 14.405ms
We are changing the matcher correspondingly, also making it more precise.
The change looks good and fixes the problem with the changed logging
output. For future, it would be also good to convert the test to Java
only, along with other JDI shell tests.
Cheers,
-JB-
Best regards,
Alexander
