> On 13 apr. 2016, at 11:06, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > > Staffan, > >> Do you know if the change in jps output was intentional or caused by >> something else? > > Sorry, I don't know what change jps output.
The problem is that the sun.java.command property has changed format with jigsaw. If the main-class is in a module the property will be on the format "jdk.jdi/com.sun.tools.example.debug.tty.TTY”. MonitoredVmUtil.mainClass() fails in parsing this new format and returns the full classname even when not to. I wonder if this is good or bad, what other dependencies there are on sun.java.command and what the impact will be... > > -Dmitry > > > On 2016-04-12 22:06, Staffan Larsen wrote: >> Thanks for the explanation. The change looks good. >> >> Do you know if the change in jps output was intentional or caused by >> something else? >> >> >>> On 12 apr. 2016, at 16:32, Dmitry Samersoff >>> <dmitry.samers...@oracle.com <mailto:dmitry.samers...@oracle.com>> wrote: >>> >>> Staffan, >>> >>> On 2016-04-12 16:32, Staffan Larsen wrote: >>>> Can you explain what is going on here? It looks like the old code >>>> looked for the TTY process, whereas the new code accepts any process. >>>> What am I missing? >>> >>> Both code select jdbCmd first: >>> >>> ll. 926 >>> jdbCmd=`$jdk/bin/jps -v | $grep $jdbKeyword` >>> >>> then old code expect: >>> >>> 12199 TTY -Dapplication.home=/opt/jdk1.8.0_77 -Xms8m >>> >>> but for latest JDK9 jps -v return full class name: >>> >>> 12281 com.sun.tools.example.debug.tty.TTY -Dapplication.home=/opt/jdk9 >>> -Xms8m -Djdk.module.main=jdk.jdi >>> >>> i.e. we get com.sun.tools.example.debug.tty.TTY instead of just TTY >>> >>> new code accept both variants. >>> >>> -Dmitry >>> >>> >>>> >>>>> On 12 apr. 2016, at 14:28, Dmitry Samersoff >>>>> <dmitry.samers...@oracle.com <mailto:dmitry.samers...@oracle.com>> >>>>> wrote: >>>>> >>>>> Everybody, >>>>> >>>>> Please review a small fix. >>>>> >>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8153856/webrev.01/ >>>>> >>>>> This fix doesn't fix root cause of the test fail but fix small test >>>>> bug to get better diagnostic. >>>>> >>>>> -Dmitry >>>>> >>>>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, >>>>> Russia * I would love to change the world, but they won't give me >>>>> the sources. >>>> >>> >>> >>> -- >>> Dmitry Samersoff >>> Oracle Java development team, Saint Petersburg, Russia >>> * I would love to change the world, but they won't give me the sources. >> > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources.
