Looks good to me.
/Erik
On 2016-04-13 22:49, Poonam Bajaj Parhar wrote:
Hello,
As per Erik's suggestion not to remove the existing check for
HS_ALT_MAKE, here is the updated webrev:
http://cr.openjdk.java.net/~poonam/8153252/webrev.01/
Thanks,
Poonam
On 4/11/2016 12:15 PM, Poonam Bajaj Parhar wrote:
Hello,
Please review this simple fix.
Bug JDK-8153252 <https://bugs.openjdk.java.net/browse/JDK-8153252>:
SA: Hotspot build on Windows fails if make/closed folder does not exist
Problem: The problem is that the SA build on windows fails while
building non-openjdk commercial sources that don't contain the
make/closed folder.
nmake -nologo -f D:\ws\8u-dev\hotspot\make\windows\makefiles\top.make
BUILD_FLAVOR=product ARCH=x86
nmake in ./generated
cd generated && "d:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\BIN\nmake.EXE" -NOLOGO -f D:\ws\8u-dev\hotspot\make\windows\makefiles\
generated.make DIR=.\generated BUILD_FLAVOR=product
D:\ws\8u-dev\hotspot/make/windows/makefiles/sa.make(54) : fatal error U1052:
file 'D:\ws\8u-dev\hotspot/make/closed/windows/makefiles/sa.make' not found
Stop.
NMAKE : fatal error U1077: 'cd' : return code '0x2'
Fix: Add a check to ensure that the make/closed folder exists.
Webrev: http://cr.openjdk.java.net/~poonam/8153252/webrev.00/
Thanks,
Poonam
