Looks fine to me. Thanks, David
On 20/04/2016 5:40 PM, Robbin Ehn wrote:
Hi all, Please review. We are missing a cr on a log stream, which leads to this guarantee. Bug: https://bugs.openjdk.java.net/browse/JDK-8154728 Thanks ! /Robbin diff -r 857efca82258 src/share/vm/prims/jvmtiExport.cpp --- a/src/share/vm/prims/jvmtiExport.cpp Sun Apr 17 19:15:52 2016 -0700 +++ b/src/share/vm/prims/jvmtiExport.cpp Wed Apr 20 09:37:01 2016 +0200 @@ -428,6 +428,7 @@ LogTarget(Trace, jvmti) log; LogStreamCHeap log_stream(log); java_lang_Throwable::print(PENDING_EXCEPTION, &log_stream); + log_stream.cr(); CLEAR_PENDING_EXCEPTION; return; }