Hi Sharath,

Can you explain more how this help with the problem in the bug? 

It looks like you are trying to avoid a race by not printing the "Input stream 
closed.” message while shutting down. You added this:
 136             ((TTY)notifier).setShuttingDown(true);
 137             Env.shutdown(shutdownMessageKey);
The call on line 137 will result in a System.exit(0) call if I am reading the 
code right. So adding the shutdown flag to line 136 will maybe make the race 
smaller, but isn’t really solving it?

What kind of testing have you run this fix through?

Thanks,
/Staffan



> On 28 apr. 2016, at 09:22, Sharath Ballal <sharath.bal...@oracle.com> wrote:
> 
> Hi,
>  
> Pls review the change for bug 
>  
> JDK-8154144 <https://bugs.openjdk.java.net/browse/JDK-8154144> - Tests in 
> com/sun/jdi fails intermittently with "jdb input stream closed prematurely
>  
> Webrev:
> http://cr.openjdk.java.net/~sballal/8154144/webrev.00/ 
> <http://cr.openjdk.java.net/~sballal/8154144/webrev.00/>
>  
> -Sharath Ballal

Reply via email to