Re: RFR (XS): 8153190 JVMTI GetAllModules should make it clear that it also returns unnamed module

[serguei.spit...@oracle.com]

On 4/28/16 02:48, Alan Bateman wrote:

On 28/04/2016 10:44, serguei.spit...@oracle.com wrote:

Please, review the JVM TI spec one-liner fix below.


The jvmti.xml patch:

diff -r 888f37103953 src/share/vm/prims/jvmti.xml
--- a/src/share/vm/prims/jvmti.xml    Wed Apr 27 11:25:16 2016 +0200
+++ b/src/share/vm/prims/jvmti.xml    Thu Apr 28 02:24:09 2016 -0700
@@ -6482,6 +6482,7 @@
       <synopsis>Get All Modules</synopsis>
       <description>
     Return an array of all modules loaded in the virtual machine.
+        This includes the unnamed module for each class loader.

Looks okay, alternative "The array include the unnamed module ...".

It makes sense, thanks.
The updated patch is:

diff -r 888f37103953 src/share/vm/prims/jvmti.xml
--- a/src/share/vm/prims/jvmti.xml    Wed Apr 27 11:25:16 2016 +0200
+++ b/src/share/vm/prims/jvmti.xml    Thu Apr 28 02:51:43 2016 -0700
@@ -6482,6 +6482,7 @@
       <synopsis>Get All Modules</synopsis>
       <description>
     Return an array of all modules loaded in the virtual machine.
+        The array includes the unnamed module for each class loader.
     The number of modules in the array is returned via
     <code>module_count_ptr</code>, and the array itself via
     <code>modules_ptr</code>.


Thanks,
Serguei

-Alan.