Thanks, looks good. (In future, please notify code owners using the relevant mailing lists, in this case core-libs-dev)
On Fri, Apr 29, 2016 at 12:32 PM, harold seigel <[email protected]> wrote: > Please review this updated webrev that uses Martin's fix: > > New webrev: http://cr.openjdk.java.net/~hseigel/bug_8155727.1/ > > Thanks, Harold > > > On 4/29/2016 3:19 PM, Martin Buchholz wrote: >> >> Apologies for taking over here ... This test is maintained externally >> in JSR166 CVS. We prefer a version that works well with both old and >> new outputs. I suggest instead >> >> "(?m)^ *[0-9]+: +([0-9]+) +[0-9]+ +\\Q"+className+"\\E(?:$| )"; >> >> Does that work with latest serviceability changes? >> >> On Fri, Apr 29, 2016 at 11:00 AM, harold seigel >> <[email protected]> wrote: >>> >>> Hi, >>> >>> Please review this extra small fix for test TimedAcquireLeak.java. The >>> test >>> was broken by the recent change to add module information to the JMAP >>> class >>> histogram. This fixes the test's regular expression to handle the >>> possible >>> additional module information. >>> >>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8155727/ >>> >>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8155727 >>> >>> Thanks! Harold >>> >
