Alan, Webrev updated in-place (press shift-reload).
-Dmitry On 2016-05-05 16:30, Alan Bateman wrote: > > On 05/05/2016 13:51, Dmitry Samersoff wrote: >> Please, see updated webrev. >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ >> >> Removed ToolProvider and update modules-info files. >> >> -Dmitry >> > Can `requires jdk.jcmd` be dropped from jdk.hotspot.agent's module > declaration? > > shouldWarnSA/warnSA is fatal (VM exits) so maybe better names are needed > for these methods. > > "Coredump access". I guess this should "Cannot connect to core dump or > remote debug server" to be clearer. > > The rest looks okay to me. > > -Alan > > > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
