Robbin, Looks good for me.
Did you test the situation when more than one pid returned ? -Dmitry On 2016-05-09 17:10, Robbin Ehn wrote: > Hi all, > > Please review this enhancement for jinfo, jstack and jmap. > > It is based on top of "8155091: Remove SA related functions from tmtools" > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-May/019609.html > > Version 5 which is reviewed but not yet pushed: > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.05/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8154985 > Webrev: http://cr.openjdk.java.net/~rehn/8154985/webrev/ > > Passes jdk/test/sun/tools/ > (or 1 test fails locally, but that tests also fails in vanilla) > And manual testing. > > Thanks! > > /Robbin -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
