> On 12 maj 2016, at 19:26, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > > Alexander, > > jmap doesn't support coredump (non-cooperative) access anymore. This > functionality moved to jhsdb. > > As a long term, we should create two different set of tests - one for > cooperative mode (jmap, jstack, etc) and one for non-cooperative mode > (jhsdb). > > Cooperative mode tests should resides alongside with other attach > related tests - i.e. in jdk/test/sun/tools
Or they could be part of the diagnostic command test suite (hotspot/test/serviceability/dcmd/) since all they do is run diagnostic commands. > > Non-cooperative mode (jhsdb) tests should be placed together with other > SA tests - in hotspot/test/serviceability/sa > > -Dmitry > > On 2016-05-12 19:27, Alexander Kulyakhtin wrote: >> Hi Dmitry, >> >> With this change we are not launching jmap anymore, launching jhsdb instead. >> I just wanted to make sure if it is ok not to test jmap anymore? >> Perhaps, instead of changing we should make the test to test both ? >> >> Best regards, >> Alexander >> >> ----- Original Message ----- >> From: dmitry.samers...@oracle.com >> To: staffan.lar...@oracle.com >> Cc: serviceability-dev@openjdk.java.net, hotspot-gc-...@openjdk.java.net >> Sent: Thursday, May 12, 2016 5:30:26 PM GMT +03:00 Iraq >> Subject: Re: RFR(S): JDK-8156769 >> gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with >> java.lang.Exception >> >> Staffan, >> >>> The GC.heap_info Diagnostic Command should really be updated to >>> contain a lot more information (similar to what SA produces). >> >>> Should we file an enhancement for that? >> >> I think yes. >> >> -Dmitry >> >> >> On 2016-05-12 17:02, Staffan Larsen wrote: >>> Looks good! >>> >>> The GC.heap_info Diagnostic Command should really be updated to >>> contain a lot more information (similar to what SA produces). Should >>> we file an enhancement for that? >>> >>> Thanks, /Staffan >>> >>> >>>> On 12 maj 2016, at 15:25, Dmitry Samersoff >>>> <dmitry.samers...@oracle.com> wrote: >>>> >>>> Everybody, >>>> >>>> Please review test changes: >>>> >>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8156769/webrev.01/ >>>> >>>> The test is updated to use jhsdb launcher instead of jmap. >>>> >>>> -Dmitry >>>> >>>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, >>>> Russia * I would love to change the world, but they won't give me >>>> the sources. >>> >> >> > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources.