David, Indeed it is a good to have fix. This API is only used by jdk.management package. Findbugs tool reported this could be potential bug. So made changes accordingly. Amit.
-----Original Message----- From: David Holmes Sent: Monday, August 01, 2016 6:10 AM To: Amit Sapre; serviceability-dev Subject: Re: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member Hi Amit, On 29/07/2016 6:20 PM, Amit Sapre wrote: > Hello, > > Please review this small fix. > > Bug : https://bugs.openjdk.java.net/browse/JDK-8162702 > > Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162702/webrev.00/ This is good defensive programming practice for exported API's, but in this case isn't this a private API only accessible to trusted code? Thanks, David > > > Amit >
