Hello, I have made changes as David suggested. Here is the new webrev link. http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.01/
Thanks, Amit -----Original Message----- From: David Holmes Sent: Monday, August 01, 2016 12:33 PM To: Amit Sapre; serviceability-dev Subject: Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly Hi Amit, On 1/08/2016 4:10 PM, Amit Sapre wrote: > Hello, > > > > Please review JNI exception handling related changes. > > Bug id : https://bugs.openjdk.java.net/browse/JDK-8162530 > > Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.00/ Sorry but that's wrong way to fix this. We should never just blindly clear exceptions and continue as if they never happened. If an exception is pending after one of these JNI calls the method should return immediately and allow the exception to propagate to the java code. Thanks, David > > > Thanks, > > Amit >
