Hello, Fixed the alignment problem as well. Here is the updated webrev. http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.02/
Thanks, Amit -----Original Message----- From: David Holmes Sent: Tuesday, August 30, 2016 11:44 AM To: Amit Sapre; serviceability-dev Subject: Re: PING : RFR : JDK-8066635 - Fix deprecation warnings in java.management module On 30/08/2016 3:56 PM, Amit Sapre wrote: > Thanks David for your inputs. > I like to go the cleanup way and made changes accordingly. > The new webrev is > http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.01/ Looks good! Only nit is the argument alignment here: ! default public ObjectInputStream deserialize(String className, ObjectName loaderName, byte[] data) they should align with each other, after the ( Thanks, David > Thanks, > Amit > > -----Original Message----- > From: David Holmes > Sent: Wednesday, August 24, 2016 12:24 PM > To: Amit Sapre; serviceability-dev > Subject: Re: PING : RFR : JDK-8066635 - Fix deprecation warnings in > java.management module > > Hi Amit, > > On 24/08/2016 4:37 PM, Amit Sapre wrote: >> >> *From:*Amit Sapre >> *Sent:* Monday, August 22, 2016 2:39 PM >> *To:* serviceability-dev >> *Subject:* RFR : JDK-8066635 - Fix deprecation warnings in >> java.management module >> >> Hello, >> >> Please review changes for fixing deprecation warnings. >> >> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8066635 >> >> Webrev : >> http://cr.openjdk.java.net/~sballal/sponsorship/8066635/webrev.00/ > > Marking the methods @Deprecated fixes the problem. > > Another option would be converting the interface methods to default methods > that throw the UnsupportOperationException and then delete them from the > DefaultMBeanServerInterceptor class. > > Your call. If you leave as-is then consider this Reviewed. > > Thanks, > David > >> >> >> Amit >>
