Hi Amit, I hadn't look at the test too closely. If you're about to fix raw types then you should fix Constructor as well - and try to compile your test with -Xlint:all to make sure nothing else has escaped :-)
No need to send a new webrev if the compiler is happy. cheers, -- daniel On 02/09/16 07:58, Amit Sapre wrote:
Thanks Alan for pointing this out. Incorporated your comments in this webrev http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.01/ Thanks, Amit *From:*Alan Bateman *Sent:* Thursday, September 01, 2016 1:46 PM *To:* Amit Sapre; serviceability-dev *Subject:* Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null. On 01/09/2016 07:01, Amit Sapre wrote: Gentle reminder ! Bug Id : https://bugs.openjdk.java.net/browse/JDK-8164730 Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.00/ <http://cr.openjdk.java.net/%7Ejgeorge/sponsorships/8164730/webrev.00/> Looks okay to me. A minor comment on the test is that innerClass should be Class<?> to avoid the raw type. -Alan
