Hi Amit,
On 07/09/16 10:34, David Holmes wrote:
Hi Amit,
On 7/09/2016 7:10 PM, Amit Sapre wrote:
Hello,
Please review the changes for missing javadoc updates for deprecated API.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8165579
Webrev :
http://cr.openjdk.java.net/~sballal/sponsorship/8165579/webrev.00/
Not sure about the "forRemoval=true" part. Given these have been
deprecated since 1.5 are we likely to ever actually remove them?
I agree with David. I wouldn't attempt to remove these methods
unless there is a strong case for it (e.g. if it was causing
some module dependency issue) - because of the potential
backward compatibility issues it may generate.
Nobody should actually be calling these methods, but there is
certainly code out there that implements them with @Override
(simply because they're declared in the interface) and tests
(JCK etc...) that probably verifies that they do throw
an exception...
Maybe Stuart (in copy) will be able to advise :-)
best regards,
-- daniel
Otherwise looks fine - and thanks for fast turnaround on this. My
apologies for overlooking it when the methods were made "default".
Thanks,
David
Thanks,
Amit
