Dmitry,

Thank you very much for the review. 

I still need a (R)eveiwer to approve the fix. Could someone, please, review 
this simple one-line change?

Best regards,
Alexander

----- Original Message -----
From: dmitry.dmitr...@oracle.com
To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net
Sent: Wednesday, October 12, 2016 5:33:45 PM GMT +03:00 Iraq
Subject: Re: RFR: 8158797: Test 
java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is specified 
explicitly

Hi Alexander,

Looks good. Please correct copyright year in the header(2015 -> 2016). 
Not need a new webrev for that.

Thanks,
Dmitry

On 10.10.2016 13:51, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review this simple, test-only change:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8158797 "Test 
> java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is 
> specified explicitly"
> Webrev: 
> http://cr.openjdk.java.net/~akulyakh/8158797/test/java/lang/management/MemoryMXBean/LowMemoryTest.java.udiff.html
>
> In order to verify some expected behavior, the test specifies its own GC 
> options when running.
> Currently, if the testing framework runs this test with some other explicitly 
> specifed GC options, then the test fails with "Conflicting collector 
> combinations in option list" message.
> We are modifying the test so that it runs only when the framework does not 
> specify any GC options.
>
> Best regards,
> Alexander

Reply via email to