Looks good to me too.

Fred

On 11/02/2016 05:58 AM, Amit Sapre wrote:
Hello,
Can I have one more review for these changes ?

-----Original Message-----
From: David Holmes
Sent: Saturday, October 29, 2016 12:22 AM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR - JDK-8006078 : [findbugs]
java.lang.management.ThreadInfo returns mutable objects

Hi Amit,

On 28/10/2016 4:12 PM, Amit Sapre wrote:
Hello,

Summary : Fixed findbugs reported warnings.

Bug ID : https://bugs.openjdk.java.net/browse/JDK-8006078

Webrev : http://cr.openjdk.java.net/~asapre/webrev/JDK-
8006078/webrev.00/

Looks okay. I hope the extra memory usage is not an issue for any
tests.

David,
I had run svc sanity tests only. If there are specific tests which I should run 
as well, Do let me know.


Thanks,
David



Thanks,

Amit

Reply via email to