Dmitry,
Thank you for the review!
Serguei
On 11/4/16 08:31, Dmitry Samersoff wrote:
Serguei,
Looks good to me.
PS: It might be better to refactor this code sometimes to don't check
the same things multiple time.
-Dmitry
On 2016-11-01 15:58, serguei.spit...@oracle.com wrote:
Please, review this small fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8160024
JDK webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8160024-JDI-eval.jdk1/
The bug is confidential, so the RFR is sent to the confidential mailing
lists.
Summary:
The JDI incorrectly evaluates the expression: Arrays.asList(null, "a").
The root cause is a special case in the method MethodImpl.handleVarArgs()
that has been corrected in order to fix the problem.
New unit test is included: jdk/test/com/sun/jdi/EvalArraysAsList.sh
Testing:
Ran new unit test, Jtreg com/sun/jdi and nsk.jdi.testlist.
All tests are passed.
Thanks,
Serguei
