Looks good!
Thanks,
David
On 8/11/2016 7:54 PM, Jini Susan George wrote:
The updated webrev: http://cr.openjdk.java.net/~jgeorge/8169344/webrev.01/
- jini.
-----Original Message-----
From: Dmitry Samersoff
Sent: Tuesday, November 08, 2016 11:22 AM
To: Jini Susan George; David Holmes; serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-8169344: Potential open file descriptor in exists() of
hotspot/agent/src/os/bsd/ps_core.c
Jini,
The fix looks OK to me (with David's suggestion).
-Dmitry
On 2016-11-08 07:39, Jini Susan George wrote:
Thank you, David. Will make this change.
-jini
-----Original Message-----
From: David Holmes
Sent: Tuesday, November 08, 2016 10:05 AM
To: Jini Susan George; serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-8169344: Potential open file descriptor in exists() of
hotspot/agent/src/os/bsd/ps_core.c
Hi,
On 8/11/2016 2:08 PM, Jini Susan George wrote:
Requesting a review for the small fix for:
https://bugs.openjdk.java.net/browse/JDK-8169344
Webrev: http://cr.openjdk.java.net/~jgeorge/8169344/webrev.00/
Looks okay but it can now simplify down to:
return access(fname, F_OK) == 0;
:)
Thanks,
David
Thanks,
- Jini Susan George
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
