On 12/5/2016 6:33 PM, Markus Gronlund wrote:
Greetings,
Kindly asking for reviews for the following changeset:
Bug/Enh: https://bugs.openjdk.java.net/browse/JDK-8170672
Webrev: http://cr.openjdk.java.net/~mgronlun/8170672/webrev01/
(this work is covered by an FC exception)
Hi Markus,
Looks good. One comment:
src/share/vm/trace/traceStream.hpp
- line #121 - you might want to check not only if the
class_loader_name_oop is NULL but also for the empty string? Much like
the code does in runtime/SharedRuntime.cpp class_loader_and_module_name()?
Thanks,
Lois
Summary:
Event-based tracing previously had little information about class loaders; a
class loader was essentially treated no different than from a regular class
(type information only).
With JDK9, supported has been added to java.lang.ClassLoader to associate a
name with an individual class loader instance.
This changeset will allow the name information of individual class loader
instances to be provided by the event-based tracing framework.
Aux info:
Some folding of the numerous macros completed as well.
Thanks in advance
Markus
