Jini, Looks good to me.
-Dmitry On 2016-12-13 11:55, Jini Susan George wrote: > Modified webrev: > > http://cr.openjdk.java.net/~jgeorge/8159127/webrev.01/ > > Thanks, > Jini. > >> -----Original Message----- >> From: Jini Susan George >> Sent: Tuesday, December 13, 2016 10:09 AM >> To: Dmitry Samersoff; [email protected] >> Subject: RE: RFR: JDK-8159127: hprof heap dumps broken for lambda >> classdata >> >> Thank you, Dmitry. I will add the null check. >> -jini >> >>> -----Original Message----- >>> From: Dmitry Samersoff >>> Sent: Monday, December 12, 2016 5:06 PM >>> To: Jini Susan George; [email protected] >>> Subject: Re: RFR: JDK-8159127: hprof heap dumps broken for lambda >>> classdata >>> >>> Jini, >>> >>> Looks good to me! >>> >>> ClassLoaderData.java >>> >>> 85: Should we check klassField for null here? >>> >>> -Dmitry >>> >>> On 2016-12-12 13:31, Jini Susan George wrote: >>>> Could I please get a review done for the following SA defect? >>>> >>>> >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8159127 >>>> >>>> Webrev: http://cr.openjdk.java.net/~jgeorge/8159127/webrev.00/ >>>> >>>> >>>> >>>> Thanks, >>>> >>>> - Jini Susan George >>>> >>>> >>>> >>> >>> >>> -- >>> Dmitry Samersoff >>> Oracle Java development team, Saint Petersburg, Russia >>> * I would love to change the world, but they won't give me the sources. -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
