Hi Harsha,

OK - makes sense to me.
Maybe just wait for tomorrow to see if you get any other comments
form other reviewers...

best regards,

-- daniel

On 22/02/17 14:38, Harsha Wardhana B wrote:
Hi Daniel,

("java.lang.RuntimePermission" "accessClassInPackage.sun.security.krb5")
was missing.

I gave all the RuntimePermissions since we don't want test cases to fail
in future.

Granting java.lang.RuntimePermission "*" does not affect the test cases
in anyway as test cases rely on delegation of specific permissions.

Regards
Harsha

On Wednesday 22 February 2017 07:43 PM, Daniel Fuchs wrote:
Hi Harsha,

Looks good - but do you really need java.lang.RuntimePermission "*" ?

What permission was missing?

best regards,

-- daniel

On 22/02/17 13:35, Harsha Wardhana B wrote:
Hi All,

Please review the below test fix for

Issue: JDK-8173130 <http://JDK-8173130> - SubjectDelegation2Test.java
and SubjectDelegation3Test.java failing on solaris

webrev : http://cr.openjdk.java.net/~hb/8173130/webrev.00/

The fix does the following.

1. Removes explicit platform check

2. Fixes JMXServiceURL

3. Adds required RuntimePermissions for test to execute.

Regards

Harsha




Reply via email to